Re: PATCH: 3.1.5-pws-10: _tar

[Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>]

Sven Wischnowsky wrote:
> It was too eager to replace `*s' with `[^/]#'s. The patch below does
> the replacement only for the non-last components.

Working a lot better now, thanks.  It's maybe a little bit eager to stick
in later path components: if I type zsh-3.1.5-pws-10/Sr<TAB> it completes
(with menucompletion) all the way to Src/.cvisignore instead of hanging
around at the next slash.  I suppose normally with ordinary completion
it'll stop after the slash because the rest is ambiguous, but that won't
always be the case.

By the way, I think you can turn things like

eval patstr\="\$patstr:gs-${sep}-\*${sep}-:gs/\*\*/\*/"

into

patstr="${${patstr//$sep/*$sep}//\*##/*}"

which not only avoids the eval, it avoids difficulties with the delimiters
since the $sep is only substituted after the /'s are parsed, plus the
characters in $sep are automatically quoted by the usual noglobsubst rule.
But you have to be careful quoting metacharacters in the `before' text.
You can also now use ## to turn multiple stars into a single one with
extendedglob.  Neither form will turn *** into a single *, since the
replacement text is never used for further matching.  I don't know if
that's a bug, but probably not.

-- 
Peter Stephenson <pws@xxxxxxxxxxxxxxxxx>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy