Re: CVS completer (Re: PATCH: Re: Completion/User functions again)

["Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>]

On Jul 21,  1:27pm, Sven Wischnowsky wrote:
} Subject: Re: CVS completer (Re: PATCH: Re: Completion/User functions again
}
} I mainly changed `compgen -f' to `_files' and `compgen -/' to `_files -/'
} and tweaked `_complete_opts' a bit so that `cvs ann -D<TAB>' doesn't
} give you `cvs ann -D-'.

Probably a list of what's still not quite right about _complete_opts should
be included in the comment at the top of it; and the usage comment should
mention that one trailing : means a required argument, two trailing : mean
an optional one, as per the latest GNU getopts.

Finally, in that vein, something ought to be done with $opt_arg besides just
including it in $with_arg.  The 'case "${#no_arg}-${#with_arg}" in' is an
interesting optimization, but I'm not sure it covers all the cases.

} Some questions:
} - And even with that in place: the `_complete_opts || _files' should
}   be reduced to `_files', right?

Yes, but again most of the _files should be changed to something that can
interpret CVS/Entries.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com