Re: PATCH: context names

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Peter Stephenson wrote:

> ...
>  
> and I still want to be able to override them with ':completion:*', which
> won't work because it's `less specific'.  Is there an advantage for
> specifying all those colons here?

No.

> In any case, I'm gradually coming round to the view that the defaults for
> styles should be hard-wired into the functions (i.e. should be set as
> values internally if style retrieval failed).  The big drawback is you
> can't see them with `zstyle'.  However, they are almost always the
> simplest, most basic behaviour, so I don't think that's a big problem (they
> should of course be documented anyway).  It's pretty normal for settings of
> any kind to have builtin defaults which you don't see.  The benefits are
> presumably obvious: everything the user enters takes precedence, nothing
> bogus (that will never be used) shows up with zstyle, nothing needs
> deleting.

Right. I won't have enough time to do this now, I'll try it later...

> Second point.
> 
> ^Xh always gives a context with no added trailing colon for the tag,
> e.g. `:completion::complete:echo:'.  I presume we're retaining the feature
> of the old system that since tags weren't always useful, the relevant colon
> wasn't added.  If we're now adopting the convention that all (other) colons
> always appear, then it might be more consistent to have the colon before
> the notional tag there too, so there would be six colons altogether, any
> time the completion context is used, with or without an actual tag at the
> end.

Oops. This was an oversight.

Bye
 Sven

diff -ru ../z.old/Completion/Commands/_complete_help Completion/Commands/_complete_help
--- ../z.old/Completion/Commands/_complete_help	Mon Feb 14 11:29:02 2000
+++ Completion/Commands/_complete_help	Mon Feb 14 11:32:09 2000
@@ -12,7 +12,7 @@
 
   for i in "${(@k)help_funcs}"; do
     text="${text}
-tags in context :completion:${i}"
+tags in context :completion:${i}:"
     for j in "${(@s.:.)help_funcs[$i][2,-1]}"; do
       text="${text}${help_tags[${i}${j}]}	(${j})"
     done

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx