PATCH: RE: side effect of "select=long"

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Andrej Borsenkow wrote:

> Not at all. We have separately completion lists AND menu
> completion/selection. First list is displayed (of course, with
> corresponding settings) and then, on the second TAB, menu
> completion/selection is started. So, that means `start selection INSTEAD
> of list if matches do not fit on the screen and start selection ON THE
> SECOND TAB always (assuming, it was not started already)'.

That's what I wanted to make possible. There was a thinko in the code, 
though, sorry. The incantation is, of course:

  zstyle ':completion:*' menu 'select=0' 'select=long-list'

Ok?

Bye
 Sven

Index: Completion/Core/_main_complete
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Core/_main_complete,v
retrieving revision 1.24
diff -u -r1.24 _main_complete
--- Completion/Core/_main_complete	2000/05/22 12:14:37	1.24
+++ Completion/Core/_main_complete	2000/05/22 12:20:49
@@ -159,9 +159,9 @@
 
   _menu_style=( "$_menu_style[@]" "$_def_menu_style[@]" )
 
-  if [[ -z "$compstate[insert]" ]]; then
-    [[ -n "$_menu_style[(r)select=long-list]" && tmp -gt LINES ]] &&
-        compstate[insert]=menu
+  if [[ "$compstate[list]" = *list &&
+        -n "$_menu_style[(r)select=long-list]" && tmp -gt LINES ]]; then
+    compstate[insert]=menu
   elif [[ "$compstate[insert]" = "$_saved_insert" ]]; then
     if [[ -n "$_menu_style[(r)select=long]" && tmp -gt LINES ]]; then
         compstate[insert]=menu

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx