Re: PATCH: test on Cygwin

["Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxxxxxxxxx>]

On May 21, 11:30am, Peter Stephenson wrote:
} Subject: PATCH: test on Cygwin
}
} +  touch unmodish
} +  chmod 000 unmodish
}    [[ -r zerolength && ! -r unmodish ]]
} +  # This works around a bug in rm -f in some versions of Cygwin
} +  chmod 644 unmodish
}  0:-r cond

That can't be right.  The test condition (`0:') depends on the test
case itself (`[[ -r ... ]]') being the last thing executed.

This is what the %clean section is for, no?

I won't yet commit the following in case I'm missing something really
obvious ...

--- zsh-forge/current/Test/C02cond.ztst	Mon May 21 07:13:53 2001
+++ zsh-4.0/Test/C02cond.ztst	Mon May 21 07:18:19 2001
@@ -19,6 +19,8 @@
   chmod u+s modish
   chmod +t modish
 
+  touch unmodish
+  chmod 000 unmodish
 %test
 
   [[ -a zerolength && ! -a nonexistent ]]
@@ -68,11 +70,7 @@
   [[ -p pipe && ! -p zerolength ]]
 0:-p cond
 
-  touch unmodish
-  chmod 000 unmodish
   [[ -r zerolength && ! -r unmodish ]]
-  # This works around a bug in rm -f in some versions of Cygwin
-  chmod 644 unmodish
 0:-r cond
 
   [[ -s nonzerolength && ! -s zerolength ]]
@@ -151,3 +149,7 @@
 
   [ `echo 0` -lt `echo 1` ]
 0:substituion in `[' builtin
+
+%clean
+  # This works around a bug in rm -f in some versions of Cygwin
+  chmod 644 unmodish

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net