Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: assume "enhanced goodness" when --multibyte-enable

X-seq: zsh-workers 22078
From: Wayne Davison <wayned@xxxxxxxxxxxxxxxxxxxxx>
To: Peter Stephenson <pws@xxxxxxx>
Subject: Re: PATCH: assume "enhanced goodness" when --multibyte-enable
Date: Wed, 14 Dec 2005 11:06:50 -0800
Cc: Zsh hackers list <zsh-workers@xxxxxxxxxx>
In-reply-to: <200512141822.jBEIMPjF027531@xxxxxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <200512141822.jBEIMPjF027531@xxxxxxxxxxxxxx>

On Wed, Dec 14, 2005 at 06:22:25PM +0000, Peter Stephenson wrote:
> Hence I think we need to make the same assumption in utils.c, too.

That certainly seems right to me.

The first hunk in your diff makes me wonder:  why isn't ucs4toutf8()
declared as static?  It is only used inside utils.c, and it sometimes
doesn't even get defined.

..wayne..

References:
- PATCH: assume "enhanced goodness" when --multibyte-enable
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author