Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Bug#377765: zsh: completion of configure script does not handle underscore properly

X-seq: zsh-workers 23247
From: "Ryo IGARASHI" <rigarash@xxxxxxxxx>
To: zsh-workers@xxxxxxxxxx, "Ryo IGARASHI" <rigarash@xxxxxxxxx>, 377765-forwarded@xxxxxxxxxxxxxxx
Subject: Re: Bug#377765: zsh: completion of configure script does not handle underscore properly
Date: Thu, 29 Mar 2007 01:20:08 +0000
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=eM99HiMNjVXy8FVIUN2qH0A+RRVgXiATMVGn0Du2/vZ1e04Ae7cBP0rWvlxz9y1bqkkZlyBLB5+XuOBAidCKsDPlDz8U6V2Ok36iqNksOEFYlIC2Vm1aMt5dDuNcHVe8N0GDfb91s8f98XFmKKVVdtIChn4RFQocGTJdfwSzdHM=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=G9qJTZVclDWYTv4gXOZW8ZaZCXxPCol7Owfo4j7TMbPw6Wz4FzC1onKvtdF073iEbM4Na2LtsLmrtLNdnZCsYZH4UBxoerX4Ig60LCNtapOQ9BNwVM9udJsliAY6y8EnBcs5jS+9X29nT02DJMijAOycAm8k3vD7wjN+s6xc0eg=
In-reply-to: <20061007095301.GA2210@xxxxxxxxxxx>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm
References: <20060711070135.40826124047@xxxxxxxxxxxxxxxxxxxxxxxxx> <20061007095301.GA2210@xxxxxxxxxxx>

Hi,

On 10/7/06, Clint Adams <schizo@xxxxxxxxxx> wrote:


This appears to fix that immediate problem.  Is there any downside to
allowing underscores?

Not committing.

Index: Completion/Base/Utility/_arguments
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Base/Utility/_arguments,v
retrieving revision 1.17
diff -u -r1.17 _arguments
--- Completion/Base/Utility/_arguments  27 Sep 2006 16:53:59 -0000      1.17
+++ Completion/Base/Utility/_arguments  7 Oct 2006 09:50:40 -0000
@@ -165,7 +165,7 @@
                     "${${opt%%\=*}//[^a-zA-Z0-9-]}=:${(L)${opt%\]}#*\=}: " )
           done
         else
-          tmpo=("${(@)${(@)tmpo%%\=*}//[^a-z0-9-]}")
+          tmpo=("${(@)${(@)tmpo%%\=*}//[^a-z0-9_-]}")

          cache=( "$cache[@]" "${(@)^tmpo}=${dir}${descr}" )
         fi


The above patch solved my problem and I haven't experienced any
side effect yet.

Well, I am very sorry for the late reply.

--
Ryo IGARASHI
rigarash@xxxxxxxxx

Follow-Ups:
- Re: Bug#377765: zsh: completion of configure script does not handle underscore properly
  - From: Clint Adams

Messages sorted by: Reverse Date, Date, Thread, Author