Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: bug with hash builtin

X-seq: zsh-workers 25984
From: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
To: Zsh workers <zsh-workers@xxxxxxxxxx>
Subject: Re: PATCH: bug with hash builtin
Date: Fri, 31 Oct 2008 21:07:57 +0000
In-reply-to: Message from Oliver Kiddle <okiddle@xxxxxxxxxxx> of "Fri, 31 Oct 2008 12:10:25 +0100." <23054.1225451425@thecus>
Mailing-list: contact zsh-workers-help@xxxxxxxxxx; run by ezmlm

Oliver Kiddle wrote:
> This was found by coverity:
> 
> hash =
> causes a seg fault.
> 
> A patch is below. I'm not sure about the error message because it isn't
> really an assignment but I can't think of anything better. Does anyone
> think it would be better to avoid the use of the continue statement here
> at the cost of having to further indent quite a few lines.

It looks OK to me.

-- 
Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

References:
- PATCH: bug with hash builtin
  - From: Oliver Kiddle

Messages sorted by: Reverse Date, Date, Thread, Author