Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 3/4] Fix git-branch -[dD] -r completion



Nikolai Weibull wrote:
> On Fri, Mar 18, 2011 at 23:26, Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx> wrote:
>> Hm, with this patch, this:
>>
>> % git branch -d -r <tab>
>>
>> works. But this:
>>
>> % git -r -d <tab>
>>
>> doesn't.
>>
>> I suppose, that's not intentional?
>
> Well, it depends on what you’re after.  Writing -r first hints that
> you want to list branches, not delete them.  If you look at the
> synopsis in the man page, that’s how I’ve done it.  Does anyone have a
> strong opinion on how this should be done?

I think _git should offer both ways simply because git accepts both
ways. Further down the git-branch(1) manpage, it states "List or delete
(if used with -d) [...]". So it's *with*, not *after*.

IMHO, _git behaving that way would make sense.

Regards, Frank



Messages sorted by: Reverse Date, Date, Thread, Author