Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

PATCH: remove duplicated local in _x_utils

X-seq: zsh-workers 31169
From: Oliver Kiddle <okiddle@xxxxxxxxxxx>
To: Zsh workers <zsh-workers@xxxxxxx>
Subject: PATCH: remove duplicated local in _x_utils
Date: Tue, 19 Mar 2013 22:46:14 +0100
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s1024; t=1363729576; bh=vS4gNiP6YA5UCVaxPqczRqODociSGkkCo8Ym0SntPLM=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Received:From:To:Subject:Date:Message-ID; b=MKwVmgMpn7AOLHkUodMf1fWaW9MN8e0ay2Iw10e6p/XIxDvpwfP3a2L6tEFNGdKr5UAa/GtOfVM+J5GFMnEfmcrSKpEQpI+QSTUrfdK6pLdxHN7GitlXoHfSypSv5kNHxSgoGsP0ejbvM2nBKBUHeXRU2lCYgj1YWhNwmTSlx7g=
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm

I noticed that completion after xhost + was outputting expl=''. This is
because it is declared local twice in _x_utils so the second time it
prints the value. This removes the duplication.

Oliver

Index: Completion/X/Command/_x_utils
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/X/Command/_x_utils,v
retrieving revision 1.5
diff -u -r1.5 _x_utils
--- Completion/X/Command/_x_utils	9 Dec 2011 15:58:35 -0000	1.5
+++ Completion/X/Command/_x_utils	19 Mar 2013 21:45:39 -0000
@@ -69,7 +69,7 @@
     '-rv'
   ;;
 xhost)
-  local expl type ret=1 tmp match
+  local type tmp match
 
   if compset -P '-'; then
     tmp=(${(f)"$(xhost)"})

Messages sorted by: Reverse Date, Date, Thread, Author