Re: Interrupting globs (Re: Something rotten in tar completion)

[Peter Stephenson <p.stephenson@xxxxxxxxxxx>]

On Fri, 5 Dec 2014 10:06:32 -0800
Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> Not speaking directly for completion, but withOUT the above patch:
> 
> % : /**/*(/)
> 
> is not interruptible.  WITH the above patch, the recursive glob can be
> interrupted.

Yes, I agree your patch is a good idea, too.  I did see a lot of
unnecessary goings on in scanner() even after errflag was being set
properly.

> } It's using an eval-style trap, so the "return" in it is forcing the
> } current function in the completion code to return with that status and
> } no error flagged.
> 
> That was actually intentional based on the behavior complaint that led
> to the trap being added.  Changing the type of trap addresses a slightly
> different problem.  What we need is some way to get both.

Well, if it aborts completely, which is certainly what I want, it will
of course return from the current function, so I've forgotten why you'd
ever want to do anything else.

pws