Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

PATCH: _yum: fix typos in cache-handling code



The following patch will fix bugs (or typos) in function
_yum_all_pkgs().

The second hank is to complete package names for
$ yum info all <TAB>


(Q1) the indentation in _yum is in disorder:
spaces; tab(s); or even tab after spaces;
should they be "fixed"?

(Q2) possibly very long, and time consuming, list of
package names is offered by a bare compadd. Should it
be wrapped in _wanted ?

Jun



diff --git a/Completion/Redhat/Command/_yum b/Completion/Redhat/Command/_yum
index ae63364..a698328 100644
--- a/Completion/Redhat/Command/_yum
+++ b/Completion/Redhat/Command/_yum
@@ -85,15 +85,14 @@ _yum()
   	fi
 }
 
-# Fills the installed pkg cache
+# Fills the all pkg cache
 _yum_all_pkgs()
 {
 	if ( [[ ${+_all_pkgs} -eq 0 ]] || _cache_invalid ALL ) &&
 		! _retrieve_cache ALL;
 	then
-		local prog="yum -C list all | sed 's/\s.*//' | grep '\.'"
-		_all_pkgs=( $(kages $prog 2>/dev/null) )
-		_store_cache ALL _all_pkg
+		_all_pkgs=( $(yum -C list all | sed 's/\s.*//' | grep '\.' 2>/dev/null) )
+		_store_cache ALL _all_pkgs
 	fi
 }
 
@@ -227,8 +226,9 @@ _yum_list_or_info()
 	else
 	    local subcmd
 		subcmd="${${listlist[(r)$words[2]:*]%%:*}}"
-		# Deal with any aliases
+		# offer packages selected by the subcommand
 		case $subcmd in
+			all) _yum_all;;
 			installed) _yum_erase;;
 			available) _yum_install;;
 			updates) _yum_update;;



Messages sorted by: Reverse Date, Date, Thread, Author