Re: A05 Test Hang

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Jan 25,  3:51pm, Bart Schaefer wrote:
}
} #1  0x00000000004a5225 in settyinfo (ti=0x7fff15c1ecc0) at utils.c:1626
} #2  0x00000000004a654b in read_poll (fd=0, readchar=0x7fff15c1ef78, polltty=1,
}     microseconds=5000000) at utils.c:2332
} #3  0x0000000000423efb in bin_read (name=0x2b528371bbb8 "read", 
} 
} If I back out the changes to polltty handling in read_poll() from 34365
} (git commit 4688de16772beffc315bbf765475a2932cbd8628) it works again.

This seems to do the trick (clearly a thinko to ignore the value of
polltty that is passed in as an argument):

diff --git a/Src/utils.c b/Src/utils.c
index 45f596a..d38babb 100644
--- a/Src/utils.c
+++ b/Src/utils.c
@@ -2323,7 +2323,7 @@ read_poll(int fd, int *readchar, int polltty, zlong microseconds)
      * as plausible as it sounds, but it seems the right way to guess.
      *		pws 2000/06/26
      */
-    if (fd >= 0) {
+    if (polltty && fd >= 0) {
 	gettyinfo(&ti);
 	if ((polltty = ti.tio.c_cc[VMIN])) {
 	    ti.tio.c_cc[VMIN] = 0;


(Damn, that one test certainly seems to uncover a bunch of random issues.)