Zsh Mailing List Archive
Messages sorted by:
Re: Possibly excessive WARN_CREATE_GLOBAL
- X-seq: zsh-workers 37198
- From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: Re: Possibly excessive WARN_CREATE_GLOBAL
- Date: Sun, 22 Nov 2015 12:30:28 -0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=from:message-id:date:in-reply-to:comments:references:to:subject :mime-version:content-type; bh=p88ur0+d09PCQCOSbCguCkyegANbDB84kxmlc51PMcE=; b=eb9ZOlC3mCIwookg4+CAf43xjZVBxxfwrHEZxHSZl7c9F+ECcTiTDVGxyB0jbeewU4 BF1FM9+OzNaCaIu06H5Vno9GMU0hdROgeqcouuiKKlUJGdImyDtdHl+tislVX/jBhqLY hV8SR7CXHV/VLZkO7BRHESu9pWAFfo7IzALN7KVW8aK10yBx5EUbBDiNprQFaT51RJ97 yI3BKZgHIhRqlHPHCVUy7dLNz0p2o+iFKX46lfFx7MDufZk2vCmishbFY6zT3ADldDXA 23pP4s+vQbHEtSTcoB4RduBpoyYsq40yO73/6VUz3jCg7JRvTal0idKIYCllyWTwjqR5 F+cw==
- In-reply-to: <201511221915.tAMJFbFW006908@localhost.localdomain>
- List-help: <mailto:firstname.lastname@example.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:email@example.com>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <201511221915.tAMJFbFW006908@localhost.localdomain>
On Nov 22, 7:15pm, Peter Stephenson wrote:
} Or do you mean it doesn't actually get set *at all*? That should surely
} trigger an error immediately in the inner scope, shouldn't it?
It doesn't get set at all.
We come into createparam() and discover at line 878 that the parameter
already exists, which is what we want, but in spite of it being flagged
PM_SPECIAL|PM_REMOVABLE all createparam() does is toggle off the PM_UNSET
flag, which seems dubious.
(And *then* it tests PM_RESTRICTED, which it seems to me ought to come
first? That's not related to this thread, but I wouldn't think you
should be able to change the unset-ness of a restricted parameter.)
Then we enter fetchvalue() at line 2926, which correctly returns that the
parameter does not have a value, and assignaparam() silently surrenders at
line 2929. Maybe there should always be an error at that point, I don't
know how else we might get there.
Messages sorted by: