Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
- X-seq: zsh-workers 39794
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>
- Subject: Re: [PATCH] Fix hexdump command used for mercurial dirstate parsing
- Date: Mon, 31 Oct 2016 18:37:23 +0000
- Cc: zsh-workers@xxxxxxx
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=QGyC557kUnhZgZp IgFFG5keqbCs=; b=GU1XjE2TvAqVF4/2sTWUBYNjThNTxQYRe2yjQQHgreXXD0m IT+dq4ERDex5rsgeHYOZzlTVSEmu2sl1NKjqlFEW5jU7pMAhSbuMZUywB+S6LK5W wgyHptyrhKnFK8Gr7kRKsDLy1KqTUojsRz+0Gf4eU8i7EjnhjYy5KtaiCQSQ=
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=smtpout; bh=QGyC557kUnhZgZ pIgFFG5keqbCs=; b=qDjTUo8hDJYGWcK/ud267EmhrcUq8002J2NasyClBr0E9y gv/2s46YYLTG20j4cxQLbxbs7Pw7c/I8FTj96fgaD8Dw6Eo9XQHSnsxvqQODw7Ms +yVNTt/7UmOyMZfBwWpESbe5v6QSRXEqOAlqoAlp/on03Vf1wb/o8tAzl+RLg=
- In-reply-to: <87pomgevp8.fsf@ft.bewatermyfriend.org>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <20161030024723.62832-1-john.reed.riley@gmail.com> <87y416drcq.fsf@ft.bewatermyfriend.org> <20161030155530.GC12137@fujitsu.shahaf.local2> <20161030170534.GA17437@fujitsu.shahaf.local2> <161030112832.ZM14753@torch.brasslantern.com> <20161030203314.GA4276@fujitsu.shahaf.local2> <87pomgevp8.fsf@ft.bewatermyfriend.org>
Frank Terbeck wrote on Mon, Oct 31, 2016 at 10:04:03 +0100:
> Daniel Shahaf wrote:
> > - && ( VCS_INFO_check_com hexdump ) && [[ -r ${dirstatefile} ]] ; then
> > + && VCS_INFO_hexdump ${dirstatefile} 20 ; then
> > # Calling hexdump is (much) faster than hg but doesn't get the local rev
>
> While we're at it, that comment should probably be adjusted as well,
> since we don't really *call* hexdump any more.
Pushed with that change. (I'd noticed it before posting the patch, but
thought the language was clear as it was.) Thanks for the review.
Messages sorted by:
Reverse Date,
Date,
Thread,
Author