Re: [Pkg-zsh-devel] zsh 5.2-test-1

[Axel Beckert <abe@xxxxxxxxxx>]

Hi,

Peter Stephenson wrote:
> On Sun, 4 Dec 2016 09:19:41 -0800
> Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> > On Dec 4,  5:08pm, Peter Stephenson wrote:
> > } Subject: Re: zsh 5.2-test-1
> > }
> > } > 14:34:54 @@ -1 +1 @@
> > } > 14:34:54 -foo:1: 1: no arguments given
> > } > 14:34:54 +%  
> > } >  
> > } > %  
> > } >  
> > } > foo:1: 1: no arguments given
> > } 
> > } I would guess this is some I/O oddity
> > 
> > Looks more to me as if PS1 is being restored despite the assignment to
> > PROMPT, possibly because PS1 has been exported into the environment by
> > the test harness?
> 
> Oh, that "+" in the diff might refer to all the following lines, in
> which case you're probably right.

I think so, yes.

> diff --git a/Test/D04parameter.ztst b/Test/D04parameter.ztst
> index 834550c..9ae6d0b 100644
> --- a/Test/D04parameter.ztst
> +++ b/Test/D04parameter.ztst
> @@ -97,7 +97,8 @@
>  
>    PROMPT="" $ZTST_testdir/../Src/zsh -fis <<<'
>    unsetopt PROMPT_SP
> -  PS2="" PS3="" PS4="" RPS1="" RPS2=""
> +  PS1="" PS2="" PS3="" PS4="" RPS1="" RPS2=""
> +  exec 2>&1
>    foo() {
>        print ${1:?no arguments given}
>        print not reached
> @@ -106,7 +107,7 @@
>    print reached
>    '
>  0:interactive shell returns to top level on ${...?...} error
> -?foo:1: 1: no arguments given
> +*>*foo:1: 1: no arguments given
>  >reached
>  
>    print ${set1:+word1} ${set1+word2} ${null1:+word3} ${null1+word4}

Thanks, tried it, but it still fails, just slightly different:

http://jenkins.grml.org/view/Debian/job/zsh-binaries/architecture=amd64/264/console

19:47:50 ../../Test/D04parameter.ztst: starting.
19:47:50 Running test: Basic scalar parameter substitution
19:47:50 Test successful.
19:47:50 Running test: Basic array parameter substitution
19:47:50 Test successful.
19:47:50 Running test: Basic ksharray substitution
19:47:50 Test successful.
19:47:50 Running test: Basic shwordsplit option handling
19:47:50 Test successful.
19:47:50 Running test: $+...
19:47:50 Test successful.
19:47:50 Running test: $+... with arrays
19:47:50 Test successful.
19:47:50 Running test: ${...:-...} and ${...-...}
19:47:50 Test successful.
19:47:50 Running test: ${...:=...}, ${...::=...}, ${...=...}
19:47:50 Test successful.
19:47:50 Running test: ${#${(A)=array=word}} counts array elements
19:47:50 Test successful.
19:47:50 Running test: ${...:?...}, ${...?...}
19:47:50 Test successful.
19:47:50 Running test: interactive shell returns to top level on ${...?...} error
19:47:50 --- /tmp/zsh.ztst.out.5687	 2016-12-04 18:47:50.125589610 +0000
19:47:50 +++ /tmp/zsh.ztst.tout.5687	 2016-12-04 18:47:50.129589609 +0000
19:47:50 @@ -1 +1,2 @@
19:47:50 +foo:1: 1: no arguments given
19:47:50  reached
19:47:50 Test ../../Test/D04parameter.ztst failed: output differs from expected as shown above for:
19:47:50   PROMPT="" $ZTST_testdir/../Src/zsh -fis <<<'
19:47:50   unsetopt PROMPT_SP
19:47:50   PS1="" PS2="" PS3="" PS4="" RPS1="" RPS2=""
19:47:50   exec 2>&1
19:47:50   foo() {
19:47:50       print ${1:?no arguments given}
19:47:50       print not reached
19:47:50   }
19:47:50   foo
19:47:50   print reached
19:47:50   '
19:47:50 Error output:
19:47:50 %  
 
%  
 
19:47:50 Was testing: interactive shell returns to top level on ${...?...} error
19:47:50 ../../Test/D04parameter.ztst: test failed.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@xxxxxxxxxx>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE