Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks



On Sat, 28 Jan 2017 11:02:24 -0800 (PST)
Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> So PAT_HEAPDUP is already there, it's just (not PAT_STATIC) ... and we
> are back to deciding whether each individual use of PAT_STATIC is safe
> WRT signals and hooks.
> 
> Should we make it explicit anyway?
> 
> diff --git a/Src/zsh.h b/Src/zsh.h
> index d022260..c387414 100644
> --- a/Src/zsh.h
> +++ b/Src/zsh.h
> @@ -1531,6 +1531,7 @@ struct patstralloc {
> 
>  /* Flags used in pattern matchers (Patprog) and passed down to patcompile */
> 
> +#define PAT_HEAPDUP	0x0000	/* Dummy flag for default behavior */

It's ages since I looked at this.  Yes, that's definitely clearer.

pws



Messages sorted by: Reverse Date, Date, Thread, Author