Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Extend (z) test with data that seemed to cause fail



On Thu, 9 Mar 2017 20:35:51 -0800
Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:

> On Mar 9, 10:05am, Peter Stephenson wrote:
> } Subject: Re: [PATCH] Extend (z) test with data that seemed to cause fail
> }
> } I've turned the file text into printable characters like this.
> 
> There are a bunch of similar unprintable characters in V11db_gdbm
> if you would like to have a go at that, too.

The only non-ASCII characters I can see are UTF-8 characters which show
up fine on my system.  They may or may not show up properly here:

漢字

They are Unicode characters 0x6f22 and 0x5b57.

I don't think it's worth hacking these into \u sequences, particularly
as it makes comparing the output more difficult.  We already need to
edit D07 in UTF-8 mode; a note should be good enough.

As they're not being treated as characters I don't think it matters
if they're not valid in other locales, either.  Or, to put it another
way, that would be a bug we ought to fix.

pws

diff --git a/Test/V11db_gdbm.ztst b/Test/V11db_gdbm.ztst
index 02bdae2..6d74cef 100644
--- a/Test/V11db_gdbm.ztst
+++ b/Test/V11db_gdbm.ztst
@@ -1,4 +1,6 @@
-# Tests for the zsh/param/private module
+# Tests for the zsh/db/gdbm module.
+# This contains literal UTF-8 characters; if editing, use
+# UTF-8 mode.
 
 %prep
 



Messages sorted by: Reverse Date, Date, Thread, Author