Re: [PATCH v2 1/2] builtins: kill: Add basic test suite

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Chris Down wrote on Sat, Feb 15, 2020 at 20:20:55 -0400:
> This is not totally comprehensive, but at least it's a start for the
> core functionality. In the next commit, we'll also use this base to add
> some regression tests.

Thanks!  I was only asking for regression tests, so unit tests are
a pleasant surprise ☺

> +  if zmodload zsh/system &>/dev/null; then
> +    (
> +      trap 'exit 19' TERM
> +      kill $sysparams[pid]
> +    )
> +  else
> +    print -u $ZTST_fd 'Cannot zmodload zsh/system, skipping kill with no sigspec'
> +  fi
> +19:kill with no sigspec
> +

Shouldn't this set $ZTST_skip, rather than print?  That variable is
documented in Test/B01cd.ztst.

+1 on the remainder of the file.

Cheers,

Daniel