Re: 4.3.4-dev-4 and 4.2.6-dev-2 available

[Peter Stephenson <pws@xxxxxxx>]

Ismail =?utf-8?q?D=C3=B6nmez?= wrote:
> One regression test fails on a linux 2.6 host;
> 
> Test ./C02cond.ztst failed: bad status 1, expected 0 from:
...
> Was testing: -N cond
> ./C02cond.ztst: test failed.
> The following may (or may not) help identifying the cause:
>   This test can fail on NFS-mounted filesystems as the access and
>   modification times are not updated separately.  The test will fail
>   on HFS+ (Apple Mac OS X default) filesystems because access times
>   are not recorded. This does not indicate a problem in the shell.
> 
> File system was local ext3.

The test is a little flaky even beyond the description above: it
attempts to force two file writes to be a second apart.  So I'd be
inclined not to worry.  Possibly two seconds would cover more bases.

Index: Test/C02cond.ztst
===================================================================
RCS file: /cvsroot/zsh/zsh/Test/C02cond.ztst,v
retrieving revision 1.17
diff -u -r1.17 C02cond.ztst
--- Test/C02cond.ztst	31 Jul 2007 14:24:26 -0000	1.17
+++ Test/C02cond.ztst	11 Dec 2007 15:15:51 -0000
@@ -125,9 +125,6 @@
 
 # can't be bothered with -S
 
-  sleep 1
-  cat unmodified
-  touch newnewnew
   if [[ $OSTYPE == "cygwin" ]]; then
     print -u$ZTST_fd "Warning: not testing [[ -N file ]] (not supported on Cygwin)"
     true
@@ -135,6 +132,10 @@
     print -u$ZTST_fd "Warning: not testing [[ -N file ]] (not supported with NFS)"
     true
   else
+    print -u $ZTST_fd 'This test takes two seconds...'
+    sleep 2
+    cat unmodified
+    touch newnewnew
     [[ -N newnewnew && ! -N unmodified ]]
   fi
 0:-N cond


-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070