Re: It seems that I find a zle -F full CPU bug

[Dominic Hopf <dmaphy@xxxxxxxxxxxxxx>]

Greetings,

I've tried applying the patch for the Fedora but unfortunately the build fails with attached output. Basically, I just did a

    git diff -u  79abe00e1d73b3f0681343a70e3e7f84e5e3d647 7e04c1a53ddada7a848753d151e18f9469788b98 -- Doc/Zsh/zle.yo Src/Zle/zle_main.c >| ~/rpmbuild/SOURCES/0001-zsh-fix-cpuload-issue.patch 

to create the patch I'm applying in the SPEC file. Is this something I have done wrong?

Regards,.

Dominic

2014-07-17 15:52 GMT+02:00 Nick Cross <nick@xxxxxxxxx>:

Hi Bart,

I compiled up https://github.com/zsh-users/zsh (SHA 4e54648add79f7cb0c0fe81e46f49817d4555f2a ) which contains

7e04c1a - 32427: avoid busy loop on closed descriptors for "zle -F" handlers (5 months ago) (Barton E. Schaefer)

I am using your second suggested 'git info in background' (http://www.zsh.org/mla/users/2014/msg00448.html) rather than http://www.zsh.org/mla/users/2014/msg00204.html and am happy to report it works fine :-) Interestingly it also fixes the multiple Ctrl-C which I reported in another thread.

Thanks!

Nick

On 16/07/14 18:50, Bart Schaefer wrote:

On Jul 16,  6:10pm, Nick Cross wrote:
} Subject: Re: It seems that I find a zle -F full CPU bug
}
} On 16/07/14 17:01, Bart Schaefer wrote:
} > On Jul 16,  2:55pm, Nick Cross wrote:
} > } Subject: Re: It seems that I find a zle -F full CPU bug
} > }
} > } Using Fedora 5.0.5 and similar background code from Bart
} > } (http://www.zsh.org/mla/users/2014/msg00448.html) I can see the same
} > } POLLNVAL high CPU from strace.
} >
} > Unfortunately I don't think there's any shell-language-level workaround.
}
} Darn ;-) Ok, is there a fix/alternative solution planned for the next
} version? (and do you happen what the schedule for that is? ).

There's already been a patch, zsh-workers/32427.  Fedora certainly has
the option of folding that in early via RPM spec if they can be caused
to care.

As for a schedule for 5.0.6, that's sort of up to Peter, who seems to be
pretty busy right now ...

--
Diese E-Mail ist nicht mit GPG signiert, da ich sie vom Webinterface aus geschrieben habe.

This mail is not signed with GPG because I wrote it from web interface.

ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_bindings..o zle_bindings.c
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_hist..o zle_hist.c
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_keymap..o zle_keymap.c
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_main..o zle_main.c
zle_main.c: In function ‘zleread’:
zle_main.c:1256:2: warning: implicit declaration of function ‘viinsert_init’ [-Wimplicit-function-declaration]
  viinsert_init();
  ^
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_misc..o zle_misc.c
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_move..o zle_move.c
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_params..o zle_params.c
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_refresh..o zle_refresh.c
zle_refresh.c: In function ‘zrefresh’:
zle_refresh.c:1646:17: warning: ‘rprompt_off’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      vcs = winw - rprompt_off;
                 ^
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_thingy..o zle_thingy.c
ccache gcc -c -I. -I../../Src -I../../Src -I../../Src/Zle -I.  -DHAVE_CONFIG_H -DMODULE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m64 -mtune=generic -fPIC -o zle_tricky..o zle_tricky.c
zle_tricky.c: In function ‘docomplete’:
zle_tricky.c:614:9: error: ‘undoing’ undeclared (first use in this function)
     if (undoing)
         ^
zle_tricky.c:614:9: note: each undeclared identifier is reported only once for each function it appears in
make[3]: *** [zle_tricky..o] Error 1
make[3]: Leaving directory `/home/dmaphy/rpmbuild/BUILD/zsh-5.0.5/Src/Zle'
make[2]: *** [modules] Error 1
make[2]: Leaving directory `/home/dmaphy/rpmbuild/BUILD/zsh-5.0.5/Src'
make[1]: *** [modules] Error 2
make[1]: Leaving directory `/home/dmaphy/rpmbuild/BUILD/zsh-5.0.5/Src'
make: *** [all] Error 1