Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: 3.1.4: (alternative) neg-argument fix

On Oct 9,  1:25pm, Peter Stephenson wrote:
} Subject: PATCH: 3.1.4: (alternative) neg-argument fix
} There was a patch from Bart back in zsh-workers/4268 to fix a problem
} with neg-argument (\e- in emacs mode), namely \e-\e1 gave you 11
} instead of 1 and so on.  Now I come to look at this, I can't get it to
} work, i.e. neg-argument won't function at all.

Hmm.  I believe you're right.  I changed the 3.1.4 code to match the
equivalent code in 3.0.5, but I missed that digitargument() zeros
zmod.tmult when MOD_TMULT isn't flagged.  (3.0.5 never zeroes zmult,
and always multiplies by it.)

} I couldn't see a way of doing this without
} adding a new flag, though that doesn't mean there isn't one.

Has the whole multiplier thing become more complicated than necessary in
3.1.4?  MOD_TMULT obviously does more than the `gotmult' global in 3.0.5

In any case, Peter's patch is preferable to mine.

} Is there any enthusiasm for upgrading universal-argument to do what
} emacs does, that is to take any following digits as part of the
} argument?

YES!  That would be so much easier than having to clamp down Alt or hit
ESC repeatedly to enter the digits.  Just remember that it also needs
to take a following `-' as part of the argument.

Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Messages sorted by: Reverse Date, Date, Thread, Author