Re: PATCH: zsh-3.1.6-dev-17: Doc/Makefile.in rule: Zsh/modlist.yo

[Tanaka Akira <akr@xxxxxxxxxxx>]

In article <slrn89q5ne.l7g.mason@xxxxxxxxxxxxxxxxxxxxx>,
  mason@xxxxxxxxxxxxxxx (Geoff Wing) writes:

> here's a patch for building Zsh/modlist.yo.  It subdues some temperamental
> sh variants (namely mine) over ``unset'' and for some reason the test was
> failing but it works when reversed.  Note also that I've removed the
> CTRL-A's from the includefile() lines: any reason they were there?

I think suspicious `|| true' should be removed.  Although it is
required because BSD make calls /bin/sh with -e, assigning empty
string works well without it.

Index: Doc/Makefile.in
===================================================================
RCS file: /projects/zsh/zsh/Doc/Makefile.in,v
retrieving revision 1.1.1.58
diff -u -r1.1.1.58 Makefile.in
--- Doc/Makefile.in	2000/02/06 06:40:38	1.1.1.58
+++ Doc/Makefile.in	2000/02/06 07:45:17
@@ -180,14 +180,14 @@
 	    echo "enditem()"; \
 	    echo "includefile(Zsh/modmenu.yo)"; \
 	    set '' $(MODDOCSRC); \
-	    unset mod1 mod2 mod3 || true; \
+	    mod1= mod2= mod3=; \
 	    test ".$$2" = . || \
 		mod2=`sed -n '1{s|^COMMENT(!MOD!||;p;q;}' < $(sdir)/$$2`; \
 	    while test ".$$2" != .; do \
-		unset mod3 || true; \
+		mod3=; \
 		test ".$$3" = . || \
 		    mod3=`sed -n '1{s|^COMMENT(!MOD!||;p;q;}' < $(sdir)/$$3`; \
-		echo "texinode(The $$mod2 Module)($${mod3+The $$mod3 Module})($${mod1:+The $$mod1 Module})(Zsh Modules)"; \
+		echo "texinode(The $$mod2 Module)($${mod3:+The $$mod3 Module})($${mod1:+The $$mod1 Module})(Zsh Modules)"; \
 		echo "sect(The $$mod2 Module)"; \
 		echo "includefile($${2})"; \
 		shift; \
-- 
Tanaka Akira