Re: 3.1.7-pre-2

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Bart Schaefer wrote:

> On Apr 30,  4:45pm, Bart Schaefer wrote:
> } Subject: Re: 3.1.7-pre-1 for the workers
> }
> } I have a couple of issues that came up after the prerelease to resolve.
> } 
> } The "read -q" bug that Sven patched in 10727.
> 
> So ... 10727 makes this work:
> 
> 	zsh -c "read -q '?Can you see this? '" < /dev/null
> 
> But the following still sends the prompt to the redirected stderr, which
> seems wrong to me:
> 
> 	zsh -c "read -q '?Can you see this? '" < /dev/null >& /dev/null
> 
> The goal is to read from the tty only after also prompting there.  Patch
> follows for consideration; I have not committed it, pending commentary.
> The first hunk is the interesting one: It seems to me there's never any
> longer a reason to send the prompt to stderr, but I may be missing some
> case where ZLE is active and yet SHTTY == -1.  (?)

Actually, I was tempted to do the same when I sent the patch, then
tried to act minimally invasive or something like that -- and couldn't 
think of the example you gave.

> The other two hunks just avoid a redundant close().

Oops. If you commit the patch... there is similar code in bin_vared()
in zle_main.c. Implemented by the same idiot. Ahem.


Bye
 Sven


--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx