PATCH: RE: PATCH: Re: zpty and controlling tty (and other fd's)

[Sven Wischnowsky <wischnow@xxxxxxxxxxxxxxxxxxxxxxx>]

Andrej Borsenkow wrote:

> > > Note fd's 3 and 13. 3 is master side of pty (child does not need it,
> > > does it?)
> >
> > Of course I tried to close it -- and on Linux this messed up the
> > parent's (i.e. the shell's) terminal settings. Don't know how this
> > came.
> 
> ...
> 
> I do not use Linux, but until this is cleared there - porbably under
> #ifndef __LINUX (or whatever)?

Of course I now can't reproduce it. So lets just put it in and see if
anyone complains. Maybe I did something else wrong back then...

Bye
 Sven

Index: Src/Modules/zpty.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/zpty.c,v
retrieving revision 1.6
diff -u -r1.6 zpty.c
--- Src/Modules/zpty.c	2000/05/05 09:12:50	1.6
+++ Src/Modules/zpty.c	2000/05/08 10:59:48
@@ -352,6 +352,7 @@
 	dup2(slave, 2);
 
 	close(slave);
+	close(master);
 
 	if (SHTTY != -1)
 	    close(SHTTY);

--
Sven Wischnowsky                         wischnow@xxxxxxxxxxxxxxxxxxxxxxx