Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: tcp cleanup and breakage

Clint Adams wrote:
> Some other things may have been fixed or broken, and some inexplicable
> changes in whitespace occurred.  I won't commit this.

No point sending a full patch at the moment (translation: I'm too lazy
to send a diff without CVS to make it for me), but desthost is being freed
twice in the final `else' of bin_ztcp.  It should probably look like:

	desthost = ztrdup(dargs[0]);

	gai_errno = zsh_getaddrinfo(desthost, destservice, &zthints, &zthost);


	if (gai_errno) {
	    /* gai_strerror could be more useful here */
	    zwarnnam(nam, "host/service resolution failure: %s: %d", desthost, gai_errno);
	    return 1;

and remove the zsfree(desthost) right at the end of that block.  Unless
it doesn't need ztrdup'ing at all any more.

Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 392070

The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
If you received this in error, please contact the sender and 
delete the material from any computer.

Messages sorted by: Reverse Date, Date, Thread, Author