Re: PATCH: options for cd and other animals

[Peter Stephenson <pws@xxxxxxx>]

Peter Stephenson wrote:
> Here's a tenative patch to rationalise the option handling for cd, as
> well as generally making the code more sane.

Both patches now committed, since there seemed to be no objections.

I resisted the temptation to tweak the comments when committing, since
at least one esteemed colleague in California has already applied the
patch, but the following should probably be recorded.

Index: Src/builtin.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/builtin.c,v
retrieving revision 1.83
diff -u -r1.83 builtin.c
--- Src/builtin.c	3 Sep 2002 09:33:37 -0000	1.83
+++ Src/builtin.c	3 Sep 2002 09:37:29 -0000
@@ -303,7 +303,15 @@
 		    argv++;
 		    break;
 		}
-		/* unrecognised options to echo etc. are not really options */
+		/*
+		 * Unrecognised options to echo etc. are not really
+		 * options.
+		 *
+		 * Note this flag is not smart enough to handle option
+		 * arguments.  In fact, ideally it shouldn't be added
+		 * to any new builtins, to preserve standard option
+		 * handling as much as possible.
+		*/
 		if (flags & BINF_SKIPINVALID) {
 		    char *p = arg;
 		    if (optstr)

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************