Re: cosmetic completion problem

[Peter Stephenson <pws@xxxxxxx>]

Bart Schaefer wrote:
> Inside that same (col >= columns) block is an fputs() call that's intended
> to make sure that the line really has wrapped when col == columns.  I'm
> not sure, looking at it, why that's only necessary when (colors).

This doesn't really help, but until I added the ZLE_UNICODE_SUPPORT
there were two separate functions, one which handled colours and one
which didn't.  I rationalised them into one with a flag for the few
local differences.

What might be more interesting is that I changed

	    if (++col == columns) {

into

	    if (col >= columns) {

which might well have introduced a subtle bug.  The reason I introduced it
was we may have characters spanning multiple columns, but perhaps those
need something more sophisticated.  (The increment now happens in one
of the immediately preceeding code branches.)

pws



This message has been scanned for viruses by BlackSpider MailControl - www.blackspider.com