Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: bindkey <whatever> history-beginning-search-backwards; echo $widgts = crash



On Mon, 21 May 2007 18:59:23 -0700
Phil Pennock <zsh-workers+phil.pennock@xxxxxxxxxxxx> wrote:
> On 2007-05-21 at 18:46 -0700, Phil Pennock wrote:
> > This is a bug when there is no widget with the supplied name; the
> > value for the type can't be calculated.  The code which loops over
> > the widgets doesn't notice that the widget doesn't really exist and
> > the code which produces a stringification doesn't handle it.
> 
> Is it better for the $widgets associative array to pretend that such a
> key doesn't exist, or to acknowledge that it does exist with undefined
> value?

I think the latter.  If the user is convinced the widget should exist
and has tried to bind something to it the shell should show as much.
The juice stains the lips, the stain acts as a warning (as it were).
(No, that doesn't really make sense.)

I've committed that patch.  Thanks.

-- 
Peter Stephenson <pws@xxxxxxx>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview



Messages sorted by: Reverse Date, Date, Thread, Author