Re: PATCH: _dpatch-edit-patch

[Clint Adams <clint@xxxxxxx>]

On Sat, Sep 29, 2007 at 06:43:14AM -0400, Clint Adams wrote:
> dpatch-edit-patch completion by Julien BLACHE.

This
1) lowercases some capitals
2) completes a colon-separated path list for -P
3) fails to actually complete shells after -l ; is there call for a
   generic utility function that parses /etc/shells or $(getent passwd)
   or something to get a list of shells?

Julien, does dpatch-edit-patch break with the .dpatch suffix on the
command-line or does it work whether or not it's there?

Index: Completion/Debian/Command/_dpatch-edit-patch
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Debian/Command/_dpatch-edit-patch,v
retrieving revision 1.1
diff -u -r1.1 _dpatch-edit-patch
--- Completion/Debian/Command/_dpatch-edit-patch	29 Sep 2007 11:08:47 -0000	1.1
+++ Completion/Debian/Command/_dpatch-edit-patch	29 Sep 2007 21:13:05 -0000
@@ -2,16 +2,16 @@
 
 _arguments \
   '(-d --description)'{-d,--description=}'[description for the new patch, if applicable]' \
-  '(-o --outdir)'{-o,--outdir=}'[output directory for patches]:Patch output directory:_files -/' \
-  '(-s --sourcedir)'{-s,--sourcedir=}'[source directory]:Source directory:_files -/' \
-  '(-t --tmpdir)'{-t,--tmpdir=}'[temporary directory]:Temporary directory:_files -/' \
-  '(-p --stampdir)'{-p,--stampdir=}'[stamp directory]:Stamp directory:_files -/' \
-  '(-e --exclude)'{-e,--exclude}'[list of files and directories to be excluded]:Excluded files and directories:_files' \
-  '(-b --debianonly)'{-b,--debianonly=}'[unpack .orig.tar.gz before invoking the shell]:Path to .orig.tar.gz:_files' \
+  '(-o --outdir)'{-o,--outdir=}'[output directory for patches]:patch output directory:_files -/' \
+  '(-s --sourcedir)'{-s,--sourcedir=}'[source directory]:source directory:_files -/' \
+  '(-t --tmpdir)'{-t,--tmpdir=}'[temporary directory]:temporary directory:_files -/' \
+  '(-p --stampdir)'{-p,--stampdir=}'[stamp directory]:stamp directory:_files -/' \
+  '(-e --exclude)'{-e,--exclude}'[list of files and directories to be excluded]:excluded files and directories:_files' \
+  '(-b --debianonly)'{-b,--debianonly=}'[unpack .orig.tar.gz before invoking the shell]:path to .orig.tar.gz:_files' \
   '(-k --keeptemp)'{-k,--keeptemp}'[keep working source tree after exit]' \
   '(-c --clean)'{-c,--clean}'[clean the current directory]' \
-  '(-l --shell)'{-l,--shell=}'[shell to be invoked]' \
-  '(-P --origtargzpath)'{-P,--origtargzpath=}'[colon-separated list of paths containing upstream tarballs, use with -b]:Path to upstream tarballs:_files -/' \
-  '(-h --help)'{-h,--help}'[Help text]' \
-  '1:Patch name:_files -W $PWD/debian/patches -g "*.dpatch"' \
-  '2:Base patch name:_files -W $PWD/debian/patches -g "*.dpatch"'
+  '(-l --shell)'{-l,--shell=}'[shell to be invoked]:shell:' \
+  '(-P --origtargzpath)'{-P,--origtargzpath=}'[colon-separated list of paths containing upstream tarballs, use with -b]:path to upstream tarballs:_dir_list' \
+  '(-h --help)'{-h,--help}'[help text]' \
+  '1:patch name:_files -W $PWD/debian/patches -g "*.dpatch"' \
+  '2:base patch name:_files -W $PWD/debian/patches -g "*.dpatch"'