Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: add support for stgit in VCS_Info



Julien Langer <julien.langer@xxxxxxxxxxxxxx>:
> This patch adds some support for stgit to VCS_Info. It displays the
> currently active patch and the number of unapplied patches.
> The additional info is configured via a new "stgitformat" style and is put
> into the "misc" part of the prompt. I don't know if this is the best idea,
> what do you (Frank?) think?

One thing, the rest of VCS_INFO_get_data_git() uses four spaces for
indenting and the patch mixes tabs into that.

Also when introducing a new style, a documentation update would be
nice. :)

Apart from that, technically the patch itself looks fine, IMO.
However, I don't use stgit myself, so I can't give it a test drive.

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925



Messages sorted by: Reverse Date, Date, Thread, Author