Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Updated _git completion (not attached)



On Fri, Mar 18, 2011 at 14:18, Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx> wrote:

> Nikolai Weibull wrote:
> [...]
> > OK, I’ve fixed the bugs and suggestions made in this thread.  How do
> > you (that is, the Zsh maintainers) want them submitted?  As a patch
> > series to this list?
>
> This document details how patches should be submitted:
>
> <
> http://zsh.git.sourceforge.net/git/gitweb.cgi?p=zsh/zsh;a=blob_plain;f=Etc/zsh-development-guide;hb=HEAD
> >
>

This document doesn't mention it yet, but I assume it's best to submit
patches in the message body rather than as attachments? (Unless, I suppose,
they contain binary content.)

That being said, the output of "git format-patch" is usable,
> too. Exchanging git's default "[PATCH]" by "PATCH: " would be extra
> sugar.
>

Running perl -pi -e 's/^(Subject: ).(PATCH[^]]*)./$1$2:/' *.patch on
format-patch files fixes that (it seems command line options to git can't).
Maybe a useful note for the dev guide?

-- 
 / Johan Sundström, http://ecmanaut.blogspot.com/


Messages sorted by: Reverse Date, Date, Thread, Author