Zsh Mailing List Archive
Messages sorted by:
Re: Slowness issue with git completion
- X-seq: zsh-workers 29065
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Felipe Contreras <felipe.contreras@xxxxxxxxx>
- Subject: Re: Slowness issue with git completion
- Date: Tue, 26 Apr 2011 23:13:00 +0200
- Cc: Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx>, zsh-workers@xxxxxxx, Nikolai Weibull <now@xxxxxxxx>
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/q9T6OVNhO4o+DhQz/z3uA5aUDxiJcEMHOEC8eCkqTs=; b=Cj6Nb4VixuIWJiaVkJV4far/ensa76BWfnQuOWQ7d95FCLm4iHmKML05H8hg70Ab/W 2bZD3wPsK5noBY5/IP5/0ple0egNboHNwE+KvxK9j9iH1gNwFknMYeFAELenJyUJfGXD fhN/1LzrbAyLpg52yIa5xF9XPbzdsTk3N2VTk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=UORLR5sdSNwyCRWXPIVrOy21vIksfAR9obsZZSua9RGf/QVUEqittxzoeHbgRDS9iX wVI2x68Q2ZdROP8uIrxJgIvJTCczIS5cqXv/6Bw3nBYXh7XqZBWIMPlMA9U/sUEzJMZC t5ccn6UvCIss+029J3CkCxaPUd7vKJ81Jq/KY=
- In-reply-to: <BANLkTikwk=OUQ7TzQB6FNcD2wztj+LHOGw@mail.gmail.com>
- List-help: <mailto:email@example.com>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:firstname.lastname@example.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <BANLkTinKo=W8umz=JfneD3MNYdmv=xYhFQ@mail.gmail.com> <email@example.com> <BANLkTim6WJWCrfLokA045Sc8su8DMXnKNw@mail.gmail.com> <BANLkTi=eLWad_TB4L=chD=3Fb_Pd9AQyqQ@mail.gmail.com> <BANLkTi=PrLsikjVhA-e06gjEkkxDpsdVaw@mail.gmail.com> <BANLkTi=N0DjXbf70LCo422DQ_2b0_dK_AQ@mail.gmail.com> <BANLkTikwk=OUQ7TzQB6FNcD2wztj+LHOGw@mail.gmail.com>
On 26 April 2011 23:10, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:
> On Tue, Apr 26, 2011 at 11:59 PM, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>>>> git accepts files with or without a --
>> So if the command works, we should complete it.
> Even if it's so slow that it is unusable? I don't understand the urge
> to have that, nobody seems to be complaining about that behavior with
> the bash completion. Even git itself warns when you have a ref and a
> file that are ambiguous; you need to manually add "--".
It's only slow in repos as large as the linux one.
> BTW. The actual behavior is: if there's a ref, go for refs, if there's
> no ref, try the files. So 'git show v' first would show the version
> refs, but 'git show vi' will show the 'virt' directory. I don't see
> how that is so atrocious. You can still auto-complete commands that
>>>>> Moreover, why do you want to be smarter than git? There are ways to
>>>>> ask git precisely what we want: list the contents of certain tree-ish
>>>>> on-demand. And in fact, that's exactly what the bash completion does:
>>>>> time git ls-tree HEAD -- (0m0.005s)
>>>>> time git ls-tree HEAD -- drivers/ (0m0.007s)
>>>> git ls-tree doesn't allow you to filter the output files by 'changed',
>>>> 'new', 'unknown' etc etc.
>> So we can use ls-tree for log i guess, but not for much else, git add
>> will still be slow for example.
> Why do you need any git command at all to find completions for 'git
> add'? Just use the normal local file completion.
Because you don't want to complete unchanged files when adding?
Messages sorted by: