Re: Speed improvement patch for __git_files and __git_files_relative

[Mikael Magnusson <mikachu@xxxxxxxxx>]

On 11 May 2011 15:27, Frank Terbeck <ft@xxxxxxxxxxxxxxxxxxx> wrote:
> Nikolai Weibull wrote:
>> I’ve now put together a patch for __git_files and
>> __git_files_relative.  __git_files is a lot faster than previous
>> versions and __git_files_relative should be a lot faster too, now that
>> it only uses substitutions.  (Well, there’s a for loop that iterates
>> over the file names to determine the common path prefix, but I see no
>> way of avoiding it.)
>>
>> It would be great if this could make it into the 4.3.12 release, so
>> please give it a try as soon as possible.
>
> Alright, I've been trying this.  The speed improvement in my linux
> kernel clone is quite impressive.
>
> I'm running into a segfault, though. The git repository is located in
> `/tmp/linux-2.6'. I've changed a file (fs/adfs/dir.c) slightly and I'm
> doing this:
>
>  % git add f<tab>
>  % git add fs/<tab>
>  % git add fs/adfs/<tab>
>
> And that's where the shell crashes. It's a build of today's HEAD.
>
> The kernel repository was cloned from this URI:
> <git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git>
>
> I don't have the time to look into this right now, so here's a back
> trace:

This crash seems to be getting pretty common now...
http://www.zsh.org/mla/workers/2011/msg00391.html
http://www.zsh.org/mla/workers/2011/msg00513.html

-- 
Mikael Magnusson