Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer



[-CC: Clint Adams; his email address seems to be bouncing email]

Frank Terbeck wrote:
> So, do we take this patch as well or do we want to spend time on
> fleshing out the helper function? Both would work for me, to be
> honest. :)

You can apply this as-is if you like: I'll submit a patch factoring
out this code into a fresh function soon.  In the meantime, can
someone tell me how to test _git quickly?  I don't want to have to
re-compile, install, and start a new shell to test a small change.

Besides, there are plenty of other related problems.  Off the top of my head:

1. There's only some small logic for invoking __git_committish_range.
What happens to other kinds of revision specs?  Think completions for
stuff like :/quuxery, pu@{1}^2~300, ..next, bar@{2 days ago},
v1.7-679-g3bee7fb etc.  It might be too hard to support everything,
but we can certainly improve over just a <since>..<until> range.

2. log, shortlog, and blame should use rev-spec-or-file (a generalized
version of commit-range-or-file).

3. reset, checkout, and grep should use treeish-or-file.

Thanks.



Messages sorted by: Reverse Date, Date, Thread, Author