Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory

Marc Finet wrote:
> Sorry for lack of reactivity ;|.

Sorry about that. I've been a fair bit busy the last months, getting my
masters thesis out the door and starting a new job. I'm slowly trying to
catch up with my backlog now.

> On Thu, Oct 16, 2014 at 10:17:56AM +0200, Frank Terbeck wrote:
>> Marc Finet wrote:
>> > So applied and unapplied lists are considered differents. The
>> > .pc/applied-patches file contains only relative paths.
>> I see. That could be fixed, I guess. Either by making the unapplied list
>> absolute, or by trimming off the "repository's" root-directory from the
>> absolute paths before comparing.
> I do not see the point of specifying an absolute path for
> QUILT_PATCHES (or quilt-patch-dir) since relative path work with quilt
> (it automatically looks for upper directories if needed). Worse,
> specifying absolute path in QUILT_PATCHES makes quilt unable to create
> the .pc in the root since there is no root to deduce; on relative path,
> root is the path where the QUILT_PATCHES path is found.  Anyway, the
> following patch fixes all the cases, i.e. specifying path (both absolute
> or "relative") in QUILT_PATCHES or quilt-patch-dir.

My idea about absolute directory names with $QUILT_PATCHES was to keep
the patch directories in a separate place that was unrelated to the
location of the source code.

I guess you're running with this patch enabled now, right? If this
current version works for you, I'd like to push it to the central
repository now.

Regards, Frank

Messages sorted by: Reverse Date, Date, Thread, Author