Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
PATCH 09/17: complist: Fix leak of string in clnicezputs
- X-seq: zsh-workers 34119
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Subject: PATCH 09/17: complist: Fix leak of string in clnicezputs
- Date: Tue,  6 Jan 2015 06:25:41 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com; s=20120113;        h=from:to:subject:date:message-id:in-reply-to:references;        bh=VuYjaGVt3akkSB+iaK51OOnomJKSMplLp39evYnX+F0=;        b=tEsGPmMlvjXFpnSV1pdfXZWIsHnMpPBa9ucmSQDr5ZLVUltX+P5AcAlZp3YAP7YTmh         8mu/FH5vsTKiulMyQ+hEl92O8SVD3V1IsnskDFYYbmBvQpE3rfy8FDLKTluitrsVsp9w         QWqzRF0VbZy7dM/11/ZbalgiYStfzlLsVgTy4JlV/vrCoO3rhVb4CGO8pNGIUV1h/sfl         6sYpzGAqDIpTPT9j1uNqtJcML04XIdVmJiOMC0lcg45NCYx0HnCFJP2qUD+aaF/FmSBR         CFQq4HdAvcTN8/OC1E8mVjz92PRcahqMaelPMad4ahwROj/i11iHLZKlcoGUmB52IpQ2         lhEg==
- In-reply-to: <1420521949-30483-1-git-send-email-mikachu@gmail.com>
- List-help: <mailto:zsh-workers-help@zsh.org>
- List-id: Zsh Workers List <zsh-workers.zsh.org>
- List-post: <mailto:zsh-workers@zsh.org>
- Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
- References: <1420521949-30483-1-git-send-email-mikachu@gmail.com>
Found by Coverity (Issue 1255808).
---
 Src/Zle/complist.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/Src/Zle/complist.c b/Src/Zle/complist.c
index b6e7e30..80e5bf9 100644
--- a/Src/Zle/complist.c
+++ b/Src/Zle/complist.c
@@ -780,6 +780,7 @@ clnicezputs(int do_colors, char *s, int ml)
 	    /* Is the screen full? */
 	    if (ml == mlend - 1 && col == zterm_columns - 1) {
 		mlprinted = ml - oml;
+		free(ums);
 		return 0;
 	    }
 	    if (t < wptr) {
@@ -804,6 +805,7 @@ clnicezputs(int do_colors, char *s, int ml)
 		ml++;
 		if (mscroll && !--mrestlines && (ask = asklistscroll(ml))) {
 		    mlprinted = ml - oml;
+		    free(ums);
 		    return ask;
 		}
 		col -= zterm_columns;
-- 
2.2.0.GIT
Messages sorted by:
Reverse Date,
Date,
Thread,
Author