Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: hist: remove wrong NULL terminator

X-seq: zsh-workers 34190
From: Ray Andrews <rayandrews@xxxxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Subject: Re: PATCH: hist: remove wrong NULL terminator
Date: Fri, 09 Jan 2015 13:39:06 -0800
Cc: zsh workers <zsh-workers@xxxxxxx>
In-reply-to: <CAHYJk3TfLxqaHxPF6Vn+HNXzip8VbXLpsNo5Oyej8cVdFZteyw@mail.gmail.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1420807419-9270-1-git-send-email-mikachu@gmail.com> <54B013C5.6090307@eastlink.ca> <CAHYJk3TfLxqaHxPF6Vn+HNXzip8VbXLpsNo5Oyej8cVdFZteyw@mail.gmail.com>

On 01/09/2015 11:38 AM, Mikael Magnusson wrote:

Yes, but it's actually pretty harmless, most other variables on thestack in that function are never used if we enter this codepath.


I guess so, since otherwise there'd be crashes all over the place. Still, it
has a lethal look about it.  Trying to understand the culture of the project
I find myself wondering how things like that pass unnoticed, given the
unquestioned skill level of the people involved.

Follow-Ups:
- Re: PATCH: hist: remove wrong NULL terminator
  - From: Peter Stephenson

References:
- PATCH: hist: remove wrong NULL terminator
  - From: Mikael Magnusson
- Re: PATCH: hist: remove wrong NULL terminator
  - From: Ray Andrews
- Re: PATCH: hist: remove wrong NULL terminator
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author