Re: 'cd' built-in crashed zsh on a broken file system

[Kamil Dudka <kdudka@xxxxxxxxxx>]

On Tuesday 20 January 2015 20:34:36 Peter Stephenson wrote:
> On Tue, 20 Jan 2015 10:28:10 -0800
> 
> Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> > On Jan 20,  1:35pm, Kamil Dudka wrote:
> > } Subject: 'cd' built-in crashed zsh on a broken file system
> > }
> > } It is not clear to me why pwd was NULL after the return from
> > cd_new_pwd()
> > 
> > xsymlink() in utils.c:
> >     if (*s != '/')
> > 	
> > 	return NULL;
> > 
> > called from findpwd() also utils.c, which in turn is only called if you
> > have CHASE_LINKS set.
> > 
> > I'm not sure if the right thing to do is test the return of xsymlink()
> > down in findpwd(), or to check the return of findpwd() in cd_new_pwd().
> 
> I'd say the latter:  dealing with an I'm-sorry-dave-I-can't-do-that is a
> bit neater higher up otherwise the intermediate return values are in
> some sort of limbo.
> 
> I don't think there's any point in printing an error message: we don't
> know what happened, so just pretend it didn't.
> 
> How about this?

Thanks for the patch!  I have applied it on Fedora packages, will let you
know if the problem occurs from now on.

Kamil