Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

completion: git: --fixup: problem with _describe -2V and duplicate commit subjects

X-seq: zsh-workers 34768
From: Daniel Hahler <genml+zsh-workers@xxxxxxxxxx>
To: Zsh Hackers' List <zsh-workers@xxxxxxx>
Subject: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects
Date: Mon, 23 Mar 2015 23:05:24 +0100
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thequod.de; h= content-transfer-encoding:content-type:content-type:subject :subject:mime-version:user-agent:from:from:date:date:message-id :received:received; s=postfix2; t=1427148324; bh=Cxq8H7BLD+9yPzD hXTiJs8kiQj0qnTa1bGIpBzTeOj8=; b=es+SjF8w9gWANqGezdDZMvAlKkgEV5V +17mJ3RoB6Qrx2zHFStQSdMA9c4g+urIZwBll/GQFgkmwWoGByw09ro1MBhhtLxt fg2qG+zleSH7TPNiuUW/EC4aDrB383QWck+SsNAYnDe9awK2gZRXEq27nuIlqwWw gVMTz8XAc0Vg=
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I've noticed that with duplicate descriptions for different commits,
the new completion for --fixup (__git_recent_commits) does not behave
properly, triggered by the "-2V" used with _describe.

When completing "git commit --fixup=" in a repo with two commits having
"init" as its subject:

Without "-2V":

 -- commit object name --
b1fc0ca  05a98c0  -- init                                                         

With "-2V":

 -- commit object name --
- -- init                                                         
 -- commit object name --
b1fc0ca                          05a98c0

This does not only affect the duplicate commits, but will move all
hashes to a separate "commit object name" section, leaving the
descriptions without them.

This was added in 236da69, where the options are passed on to next_label.


Regards,
Daniel.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iD8DBQFVEI4jfAK/hT/mPgARAmF/AKDwkOg7vI6dxorebP0u7ykceLuV5gCcDBOj
0H8Vrng3rwCE8mmTU6tK4x0=
=5L0N
-----END PGP SIGNATURE-----

Follow-Ups:
- Re: completion: git: --fixup: problem with _describe -2V and duplicate commit subjects
  - From: Daniel Hahler

Messages sorted by: Reverse Date, Date, Thread, Author