Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value

X-seq: zsh-workers 35243
From: Kamil Dudka <kdudka@xxxxxxxxxx>
To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
Date: Wed, 20 May 2015 19:35:13 +0200
Cc: zsh-workers@xxxxxxx
In-reply-to: <150520102300.ZM26712@torch.brasslantern.com>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
References: <1432059854-2109-1-git-send-email-kdudka@redhat.com> <4003127.y1UWooicOC@kdudka.brq.redhat.com> <150520102300.ZM26712@torch.brasslantern.com>

On Wednesday 20 May 2015 10:23:00 Bart Schaefer wrote:
> On May 20,  4:43pm, Kamil Dudka wrote:
> }
> } Good catch!  Then your patch certainly looks as a better choice to me.
> 
> It belatedly occurs to me that adding
> 
>     if (!value)
> 	value = "";
> 
> would have been a sufficient change.  Oh, well.

I am quite new to zsh code but this drives me to a question: Are the strings 
allocated in mkenvstr() freed anywhere?

Kamil

Follow-Ups:
- Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Kamil Dudka

References:
- [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Kamil Dudka
- Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Kamil Dudka
- Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author