Re: [PATCH] __git_commit_objects_prefer_recent: local ret

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On May 21,  8:37pm, Daniel Hahler wrote:
}
} > Wouldn't it make more sense to put "local ret" in _get_recent_commits ?

s/get/git/ (my bad)

} I'm not sure - I've thought it was not used there on purpose, for when
} it gets called for --fixup and --squash?

No, I don't think it is -- "ret" is not declared by _git_commit either,
so the one from _arguments would be getting modified, but that's not part
of the defined interface to _arguments ... it could make _arguments wrong
in the event that _git_recent_commits returns nonzero, in fact.

The right thing is to localize ret and return it (the return statement was
already added by commit 895408bb) both in _git_recent_commits.