Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] allocate origline by ztrdup(), not by dupstring()

X-seq: zsh-workers 35563
From: Peter Stephenson <p.stephenson@xxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: [PATCH] allocate origline by ztrdup(), not by dupstring()
Date: Mon, 22 Jun 2015 09:36:44 +0100
In-reply-to: <4F8A1056-198B-4CF1-A167-7C3060F77B10@kba.biglobe.ne.jp>
List-help: <mailto:zsh-workers-help@zsh.org>
List-id: Zsh Workers List <zsh-workers.zsh.org>
List-post: <mailto:zsh-workers@zsh.org>
Mailing-list: contact zsh-workers-help@xxxxxxx; run by ezmlm
Organization: Samsung Cambridge Solution Centre
References: <1000D010-B07A-4F19-A566-8CA95B061D58@kba.biglobe.ne.jp> <24973.1434473665@thecus.kiddle.eu> <4F8A1056-198B-4CF1-A167-7C3060F77B10@kba.biglobe.ne.jp>

On Sun, 21 Jun 2015 20:53:49 +0900
Jun T. <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
> 2015/06/17 01:54, Oliver Kiddle <okiddle@xxxxxxxxxxx> wrote:
> 
> > This part is run when pressing backspace, it seems to always be the case
> > that origline == u->origline before this block runs. So it is copying freed
> > memory.
> 
> Backspace (in the interactive mode) seems to work as expected with the
> following patch. Does this look reasonable?

I certainly can't see how this could have bad effects.

pws

References:
- [PATCH] allocate origline by ztrdup(), not by dupstring()
  - From: Jun T.
- Re: [PATCH] allocate origline by ztrdup(), not by dupstring()
  - From: Oliver Kiddle
- Re: [PATCH] allocate origline by ztrdup(), not by dupstring()
  - From: Jun T.

Messages sorted by: Reverse Date, Date, Thread, Author