Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Re: Undo and narrow-to-region (was ...)

On Aug 17,  2:58pm, I wrote:
} Oliver may not be able to get to this for a while.  Is it possible for
} you to try reverting just the change to the narrow-to-region shell code
} and see if that fixes things, or if both the shell and C code changes
} need to be reverted?

I was able to reproduce the broken behavior with 832130c and then back
that out to determine that Daniel's example works correctly with the
previous version of narrow-to-region.

Oliver said:
> This is still not perfect with history changes.

In fact it's actually horribly broken with respect to history changes,
at least with -R / -S, as far as I can tell ...

In Daniel's example, we start with BUFFER='', record $UNDO_CHANGE_NO,
wander about in the history a bit, then do "zle undo $_ntr_changeno"
with the expectation that will return us to the previous state, that
is, an empty BUFFER.  But it doesn't.

It mostly works as long as BUFFER isn't empty when $UNDO_CHANGE_NO is
saved.  This goes back to Oliver's grumbling that undo decides what to
do based on whether the text on the line matches the text at the undo
point,  In this case there is no text at the undo point, so anything
will match and nothing gets undone.

The following brute-forces the history back to the same line where the
undo point was set before performing the undo.  This works for Daniel's
example but I have no idea what it will do for other cases.  It can't
make things any worse, in theory.

diff --git a/Functions/Zle/narrow-to-region b/Functions/Zle/narrow-to-region
index 0ef28a8..261d821 100644
--- a/Functions/Zle/narrow-to-region
+++ b/Functions/Zle/narrow-to-region
@@ -32,7 +32,7 @@ setopt localoptions noshwordsplit noksharrays
 local _ntr_newbuf _ntr_lbuf_return _ntr_rbuf_return
 local _ntr_predisplay=$PREDISPLAY _ntr_postdisplay=$POSTDISPLAY
-integer _ntr_savelim=UNDO_LIMIT_NO _ntr_changeno
+integer _ntr_savelim=UNDO_LIMIT_NO _ntr_changeno _ntr_histno=HISTNO
 integer _ntr_start _ntr_end _ntr_swap _ntr_cursor=$CURSOR _ntr_mark=$MARK
 integer _ntr_stat
@@ -108,7 +108,7 @@ if [[ -n $_ntr_save || -z $_ntr_restore ]]; then
     builtin typeset -ga $_ntr_save
     set -A $_ntr_save "${_ntr_predisplay}" "${_ntr_postdisplay}" \
 	"${_ntr_savelim}" "${_ntr_changeno}" \
-	"${_ntr_start}" "${_ntr_end}" || return 1
+	"${_ntr_start}" "${_ntr_end}" "${_ntr_histno}" || return 1
@@ -135,13 +135,15 @@ if [[ -n $_ntr_restore || -z $_ntr_save ]]; then
-	   _ntr_end="${${(@P)_ntr_restore}[6]}" }; then
+	   _ntr_end="${${(@P)_ntr_restore}[6]}"
+	   _ntr_histno="${${(@P)_ntr_restore}[7]}" }; then
       zle -M Failed. >&2
       return 1
+  HISTNO=_ntr_histno
   zle undo $_ntr_changeno

Barton E. Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author