Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Fwd: [Bug 1495151] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file"



Hi,

I received the following bug report via Ubuntu's Launchpad:

----- Forwarded message from Thue Janus Kristensen <thuejk@xxxxxxxxx> -----
Date: Sat, 12 Sep 2015 21:34:14 -0000
From: Thue Janus Kristensen <thuejk@xxxxxxxxx>
Subject: [Bug 1495151] [NEW] zsh completion for gphoto2 gives "--delete-files" instead of the correct "--delete-file"
Reply-To: Bug 1495151 <1495151@xxxxxxxxxxxxxxxxxx>
[…]

Public bug reported:

Zsh tab completion for gphoto2 has incorrect tab completion for
"--delete-file", wrongly appending an "s".

The error comes from the file

/usr/share/zsh/functions/Completion/Unix/_gphoto2

with the line

  '--delete-files[delete files given in range]:range' \

ProblemType: Bug
DistroRelease: Ubuntu 15.04
Package: zsh-common 5.0.7-5ubuntu1
[…]
https://bugs.launchpad.net/bugs/1495151
[…]
----- End forwarded message -----

I can confirm this by comparing "gphoto2 --help | fgrep delete" with
Completion/Unix/_gphoto2 in git.

Here's the according patch I'd commit:

diff --git a/Completion/Unix/Command/_gphoto2 b/Completion/Unix/Command/_gphoto2
index 95d8a49..314d83e 100644
--- a/Completion/Unix/Command/_gphoto2
+++ b/Completion/Unix/Command/_gphoto2
@@ -32,7 +32,7 @@ _arguments -s \
   '--get-all-raw-data[get all raw data from folder]' \
   '--get-audio-data[get audio data given in range]:range' \
   '--get-all-audio-data[get all audio data from folder]' \
-  '--delete-files[delete files given in range]:range' \
+  '--delete-file[delete files given in range]:range' \
   '--delete-all-files[delete all files in folder]' \
   '(-u --upload-file)'{-u,--upload-file}'[upload a file to camera]:file:_files' \
   '--capture-preview[capture a quick preview]' \

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@xxxxxxxxxxxxxxx  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@xxxxxxxxx (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://abe.noone.org/ (Web)



Messages sorted by: Reverse Date, Date, Thread, Author