Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Substitution ${...///} slows down when certain UTF character occurs

On Mon, 28 Sep 2015 09:51:42 +0100
Peter Stephenson <p.stephenson@xxxxxxxxxxx> wrote:
> It would be good to optimise the cases where the calling code in glob.c
> (for the parameter-style operators only) matches at different places along
> the string, too, which means unmetafying at a higher level.  That's
> quite a lot of work in the glob.c code, though, because we'll need to
> deal with length and switch the multibyte handlers to umetafied.
> I think a reasonable strategy would be to change the call sequence for
> pattrylen() and pattryrefs(), which are the key ones, to pass in an
> optional unmatefied string; some of the remaining calls in glob.c could
> be premoted to pattrylen which is a strict superset of pattry.  That
> would leave pattry() untouched for the majority of cases doing one-off
> matching.

This does the back-end work, with a patstralloc structure that allows
you to maintain information about an unmetafied string over calls to
pattrylen() and pattryrefs().

It uses this version of the optimisation

> 4. Have both metafied and unmetafied variants for the pattern when using
> a pure string, but only produce, and cache, the unmetafied version when
> needed for comparison. This is more effective than caching the trial
> string because the pattern is only compiled once for many uses of it ---
> we only lose out here if somebody is looping over a pattern (not just a
> trial string as in the glob code) many times i.e. either redoing
> patcompile() or using a pre-compiled pattern, and the latter isn't all that
> common in the code (I'm not sure where it does happen if it does).
> This seems to push the inefficiency out of inner loops to a frequency
> where it's probably not a noticeable factor any more.

with the cached unmetafied pure string, where needed, within the
patstralloc structure.  However, the new code here to handle the
unmetafied case isn't tested yet as there's nothing using the new
interface, which is the next step.


Messages sorted by: Reverse Date, Date, Thread, Author