Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 3/3] Constify two local variables.



On Mon, 30 Nov 2015 03:21:53 +0000
Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> I assume that v->pm->gsu.a->getfn() has no access to v->start and
> v->end, hence changing the order is safe.

Yes, the getfn() is very low level, dealing only with storage for that
parameter and having no knowledge at all of any expansion/substitution
happening above it.

> Are there any compilers that choke on 'char **const' (const pointer to pointer
> to char)?

I suspect we ditched those some years ago when we started making more
use of const, but there might be a few oddballs lying around.

By the way...

> See for example the number of uses of mkarry()

that should have been "mkarray()".  I see 19 uses, then there's
also hmkarray() which comes from the heap and is only used 3 times.

pws



Messages sorted by: Reverse Date, Date, Thread, Author