Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160105095834.ZM3834@torch.brasslantern.com>
Date: Tue, 5 Jan 2016 09:58:34 -0800
In-Reply-To: <4052A17B-0432-44A7-8A84-F615FD836FCF@kba.biglobe.ne.jp>
Comments: In reply to "Jun T." <takimoto-j@kba.biglobe.ne.jp>
        "Re: PATCH: refactor memstream for "print -v"" (Jan  6,  1:31am)
References: <160104231830.ZM20279@torch.brasslantern.com> 
	<4052A17B-0432-44A7-8A84-F615FD836FCF@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: PATCH: refactor memstream for "print -v"
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jan 6,  1:31am, Jun T. wrote:
} Subject: Re: PATCH: refactor memstream for "print -v"
}
} The last part (READ_MSTREAM) is for not adding a trailing NULL
} to buf.

Why not?  I know it's not strictly necessary given metafy(), but I was
trying to be consistent with open_memstream() which maintains a NUL at
the end of the buffer it manages.

} The cast (int)count is just to silence the following
} warning from clang:

Thanks; I was wondering if that was going to happen, though I presumed
that (x : y : -1) would automatically be converted to integer because
of -1 even if y were unsigned.  

Maybe it should be (long) though?  And I suppose the comparison should
explicitly be == -1 rather than < 0 in case mcount is ridiculusly big.