Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
From: Bart Schaefer <schaefer@brasslantern.com>
Message-Id: <160108203732.ZM19816@torch.brasslantern.com>
Date: Fri, 8 Jan 2016 20:37:32 -0800
In-Reply-To: <D151E1D6-C1CB-4BA9-BE26-3609193B6235@kba.biglobe.ne.jp>
Comments: In reply to "Jun T." <takimoto-j@kba.biglobe.ne.jp>
        "Re: PATCH: refactor memstream for "print -v"" (Jan  8,  9:32pm)
References: <160104231830.ZM20279@torch.brasslantern.com> 
	<4052A17B-0432-44A7-8A84-F615FD836FCF@kba.biglobe.ne.jp> 
	<160105095834.ZM3834@torch.brasslantern.com> 
	<DB99E1C4-5B22-4CDF-8C3D-982A4E037AA3@kba.biglobe.ne.jp> 
	<160106133012.ZM9614@torch.brasslantern.com> 
	<D151E1D6-C1CB-4BA9-BE26-3609193B6235@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: PATCH: refactor memstream for "print -v"
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

On Jan 8,  9:32pm, Jun T. wrote:
} 
} 2016/01/07 06:30, Bart Schaefer <schaefer@brasslantern.com> wrote:
} 
} > I suppose that this:
} > 
} >    ((COUNT = fread(BUF, 1, count, FOUT)) == count)
} > 
} > could correctly be replaced with
} > 
} >    (count == (count = fread(BUF, 1, count, FOUT)))
} 
} So you want to save the return value of fread() for debugging purpose?

Yes.  However:

} builtin.c:4435:36: warning: unsequenced modification and access to 'count' [-Wunsequenced]

That warning means my attempt was not successful; there's not a proper
sequence point in that expression.

} Anyway, I feel the macro is too complicated, so how about either
} 
} (b) give up saving the return value of fread()
}    ( .... && (count == fread(BUF, 1, count ,FOUT))) ? count : (size_t)-1 )

Agree that's probably the way to go.

} Sorry for taking your time.

Do not apologize, this is good.  Might be avoided if I had a test system
handy with clang on it, but I presently do not.