Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
Subject: Re: PATCH: Add zle-line-pre-redraw hook for highlighting
To: Daniel Shahaf <d.s@daniel.shahaf.name>,
 Bart Schaefer <schaefer@brasslantern.com>
References: <CAHYJk3QvRnYxLMb8XsoWB1hU92Qti_fEKt1JgxkyDARrhf1g7g@mail.gmail.com>
 <1450245754-2760-1-git-send-email-mikachu@gmail.com>
 <CAH+w=7btpFWXkgHFjHwMFWZcrVu-ap5+=PAkeidze8NJsz+SoA@mail.gmail.com>
 <20151219094913.GF2358@tarsus.local2>
Cc: Mikael Magnusson <mikachu@gmail.com>,
 Zsh hackers list <zsh-workers@zsh.org>
From: m0viefreak <m0viefreak.cm@googlemail.com>
Message-ID: <5692D87E.20304@googlemail.com>
Date: Sun, 10 Jan 2016 23:17:34 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20151219094913.GF2358@tarsus.local2>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit


On 19.12.2015 10:49, Daniel Shahaf wrote:
> Bart Schaefer wrote on Wed, Dec 16, 2015 at 00:05:01 -0800:
>> On Dec 15, 2015 10:27 PM, "Mikael Magnusson" <mikachu@gmail.com> wrote:
>>> I haven't received any complaints about 36650 from testers, so I'll go ahead
>>> and push this.
> 
> Hooray!
> 
> This should fix between 2 and 5 z-sy-h issues:
> https://github.com/zsh-users/zsh-syntax-highlighting/issues/245

One remaining issue with this approach is the fact that this new hook is
not triggered when a minibuffer such as isearch is active and BUFFER
changes.

Is it possible to add support for that, too?

I don't know the zle internals very well, and I couldn't figure out the
right spot to place a call to the hook without causing performance
issues due to multiple (useless) calls.